Hi Thomas -
I would really appreciate a fix for this. We've put several days into this issue.
Background:
--------------------------
We are using Obtics with LLBLGen Pro, one of the strongest ORMs for .NET (also from the Netherlands). All our Calculations are performed server-side in real-time (not on the client as with Silverlight). Thus - ConcurrentHashtable is EXTREMELY important so users are isolated from eachother's Calculations on the server.
Problem:
--------------------------
Obtics is not always using the ObticsEqualityComparerAttribute to do comparisons. Our breakpoints in our custom Comparer are firing, so we know we are hooked in correctly. However, Obtics is still calling .Equals or .GetHashCode on the objects themselves - instead of our Comparer. This is causing major problems.
Unwanted Side Effects, either:
1.) With Custom Comparer: Only calculations in the first screen work, no calculations in any successive screens or dialogs will function.
2.) Without Custom Comparer: All Calculations for an Entity are shared across all user sessions!! If User #1 views Entity A1, and another User #2 views Entity A2... User #1's calculations are displayed on User #2's screen.
LLBLGen Pro
--------------------------
.Equals() method is based solely on PrimaryKeys.
.GetHashCode() method is based solely on all matching field values.
Using the methods above, cloning an Entity will result in the clone & original being "equal". Also, fetching the same entity twice from the DB... both instances are considered "equal" in the LLBLGen world. Thus, Obtics will not listen to a cloned entity or a re-fetched entity - because Obtics thinks it is already listening to it, when really it's only listening to the first entity.
This is severely limiting & does not allow for multiple instances of an Entity to be calculated independently on separate screens.
We are using deep cloning extensively for child screens / dialog windows where Calculations must be made. Thus - the main screen's Calculations must be kept /completely/ separate from the child screen's Calculations. For our cloned entities to Calculate independently of the original entities, we need to enforce ReferenceEquals() comparison in Obtics. Anything less will result in disastrous cross-screen & cross-session calculations. As you can imagine - horror stories for both our users and the development team.
After days of work, we have narrowed it down to a simple unit test, which I am more than happy to provide you with.
Also, We do not create any anonymous types in our Expressions, as you have mentioned in other posts. We have read up on:
* http://obtics.codeplex.com/wikipage?title=Well-behaved&ProjectName=obtics
* http://obtics.codeplex.com/WorkItem/View.aspx?WorkItemId=5208
In Summary, We simply need Obtics to */always/* use the custom IEqualityComparer.
Please help, Thomas! You are greatly appreciated here - we hold Obtics in high regard. Look forward to hearing from you.
Thank you very much. Sincerely,
Ryan D. Hatch
Custom Comparer - Used to keep each object instance separate, so calculations are able to fire separately on two cloned entities:
---
public class RyansObticsEntityComparer : IEqualityComparer<CommonEntityBase>
{
public bool Equals(CommonEntityBase x, CommonEntityBase y)
{
// Require Same Instance
return ReferenceEquals(x, y);
}
public int GetHashCode(CommonEntityBase obj)
{
// Return Unique Instance Guid
byte[] guidBytes = obj.UniqueInstanceID.ToByteArray();
return BitConverter.ToInt32(guidBytes, 0);
}
}
[Obtics.ObticsEqualityComparer(typeof(RyansObticsEntityComparer))]
public class CommonEntityBase
{ ...
I would really appreciate a fix for this. We've put several days into this issue.
Background:
--------------------------
We are using Obtics with LLBLGen Pro, one of the strongest ORMs for .NET (also from the Netherlands). All our Calculations are performed server-side in real-time (not on the client as with Silverlight). Thus - ConcurrentHashtable is EXTREMELY important so users are isolated from eachother's Calculations on the server.
Problem:
--------------------------
Obtics is not always using the ObticsEqualityComparerAttribute to do comparisons. Our breakpoints in our custom Comparer are firing, so we know we are hooked in correctly. However, Obtics is still calling .Equals or .GetHashCode on the objects themselves - instead of our Comparer. This is causing major problems.
Unwanted Side Effects, either:
1.) With Custom Comparer: Only calculations in the first screen work, no calculations in any successive screens or dialogs will function.
2.) Without Custom Comparer: All Calculations for an Entity are shared across all user sessions!! If User #1 views Entity A1, and another User #2 views Entity A2... User #1's calculations are displayed on User #2's screen.
LLBLGen Pro
--------------------------
.Equals() method is based solely on PrimaryKeys.
.GetHashCode() method is based solely on all matching field values.
Using the methods above, cloning an Entity will result in the clone & original being "equal". Also, fetching the same entity twice from the DB... both instances are considered "equal" in the LLBLGen world. Thus, Obtics will not listen to a cloned entity or a re-fetched entity - because Obtics thinks it is already listening to it, when really it's only listening to the first entity.
This is severely limiting & does not allow for multiple instances of an Entity to be calculated independently on separate screens.
We are using deep cloning extensively for child screens / dialog windows where Calculations must be made. Thus - the main screen's Calculations must be kept /completely/ separate from the child screen's Calculations. For our cloned entities to Calculate independently of the original entities, we need to enforce ReferenceEquals() comparison in Obtics. Anything less will result in disastrous cross-screen & cross-session calculations. As you can imagine - horror stories for both our users and the development team.
After days of work, we have narrowed it down to a simple unit test, which I am more than happy to provide you with.
Also, We do not create any anonymous types in our Expressions, as you have mentioned in other posts. We have read up on:
* http://obtics.codeplex.com/wikipage?title=Well-behaved&ProjectName=obtics
* http://obtics.codeplex.com/WorkItem/View.aspx?WorkItemId=5208
In Summary, We simply need Obtics to */always/* use the custom IEqualityComparer.
Please help, Thomas! You are greatly appreciated here - we hold Obtics in high regard. Look forward to hearing from you.
Thank you very much. Sincerely,
Ryan D. Hatch
Custom Comparer - Used to keep each object instance separate, so calculations are able to fire separately on two cloned entities:
---
public class RyansObticsEntityComparer : IEqualityComparer<CommonEntityBase>
{
public bool Equals(CommonEntityBase x, CommonEntityBase y)
{
// Require Same Instance
return ReferenceEquals(x, y);
}
public int GetHashCode(CommonEntityBase obj)
{
// Return Unique Instance Guid
byte[] guidBytes = obj.UniqueInstanceID.ToByteArray();
return BitConverter.ToInt32(guidBytes, 0);
}
}
[Obtics.ObticsEqualityComparer(typeof(RyansObticsEntityComparer))]
public class CommonEntityBase
{ ...